Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore Swift Cpp Experiment #13956

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Firestore Swift Cpp Experiment #13956

wants to merge 12 commits into from

Conversation

cherylEnkidu
Copy link
Contributor

@cherylEnkidu cherylEnkidu commented Oct 23, 2024 •
edited
Loading

What is inside this PR:

  1. Add new cpp files inside Firestore/core/swift/ which is not included in existing Package.swift building directory.

  2. Create a new cpp target library FirebaseFirestoreCpp

@google-oss-bot
Copy link

google-oss-bot commented Oct 23, 2024 •
edited
Loading

2 Warnings
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)
⚠️ New public headers were added, did you remember to add them to the umbrella header?

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Apple API Diff Report

Commit: 9a41a76
Last updated: Tue Nov 12 15:40 PST 2024
View workflow logs & download artifacts

[BUILD ERROR] FirebaseFirestoreInternal

[BUILD ERROR] FirebaseFirestore

FirebaseCore

Functions

[MODIFIED] FIRFirebaseVersion
[MODIFIED] FIRFirebaseVersion 
Swift:
+  func FirebaseVersion () -> String
-  func FirebaseVersion () -> String
Objective-C:
+  NS_SWIFT_NAME ( FirebaseVersion ()) NSString * FIRFirebaseVersion ( void )
-  NSString * _Nonnull FIRFirebaseVersion ( void )

paulb777
paulb777 reviewed Oct 29, 2024
View reviewed changes
FirebaseFirestore.podspec Outdated
s.public_header_files = 'FirebaseFirestoreInternal/**/*.h'
s.public_header_files = [
'FirebaseFirestoreInternal/**/*.h',
'Firestore/Swift/Source/SwiftAPI/*.swift',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift files should not be in the headers

@cherylEnkidu cherylEnkidu marked this pull request as ready for review October 29, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: core api: firestore public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cherylEnkidu @google-oss-bot @paulb777