-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nc/custom signal #13976
Open
tusharkhandelwal8
wants to merge
13
commits into
main
Choose a base branch
from
nc/custom-signal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nc/custom signal #13976
+428
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 766bca0 FirebaseRemoteConfigClassesFIRRemoteConfig[ADDED] -setCustomSignals:WithCompletion:Objective-C:
+ - ( void ) setCustomSignals :( nullable NSDictionary < NSString * , NSObject *> * ) customSignals WithCompletion :( void ( ^ _Nullable )( NSError * _Nullable error )) completionHandler NS_REFINED_FOR_SWIFT ; Constants[ADDED] FIRRemoteConfigCustomSignalsErrorDomain[ADDED] FIRRemoteConfigCustomSignalsErrorDomainSwift:
+ let RemoteConfigCustomSignalsErrorDomain : String
Objective-C:
+ extern NS_SWIFT_NAME ( RemoteConfigCustomSignalsErrorDomain ) NSString * const FIRRemoteConfigCustomSignalsErrorDomain Enumerations[ADDED] FIRRemoteConfigCustomSignalsError[ADDED] FIRRemoteConfigCustomSignalsErrorSwift:
+ typealias RemoteConfigCustomSignalsError . Code . _ErrorType = RemoteConfigCustomSignalsError
+ case unknown = 8001
+ case invalidValueType = 8002
+ case limitExceeded = 8003
Objective-C:
+ enum FIRRemoteConfigCustomSignalsError : NSInteger {}
+ FIRRemoteConfigCustomSignalsErrorUnknown = 8001
+ FIRRemoteConfigCustomSignalsErrorInvalidValueType = 8002
+ FIRRemoteConfigCustomSignalsErrorLimitExceeded = 8003 |
themiswang
reviewed
Oct 29, 2024
themiswang
reviewed
Oct 29, 2024
themiswang
reviewed
Oct 29, 2024
themiswang
reviewed
Oct 29, 2024
karenyz
reviewed
Oct 30, 2024
karenyz
reviewed
Nov 8, 2024
karenyz
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(rc): Add method to set custom signals for Remote Config Custom targeting