add more unit tests for order by normalization

firebase · Aug 17, 2023 · 226a754 · 226a754
1 parent 642186c
commit 226a754
Showing 1 changed file with 45 additions and 0 deletions.
diff --git a/packages/firestore/test/unit/core/query.test.ts b/packages/firestore/test/unit/core/query.test.ts
@@ -783,6 +783,7 @@ describe('Query', () => {
       query(
         'foo',
         filter('a', '<', 5),
+        filter('a', '>=', 5),
         filter('aa', '>', 5),
         filter('b', '>', 5),
         filter('A', '>', 5)
@@ -869,6 +870,50 @@ describe('Query', () => {
       orderBy('d'),
       orderBy(DOCUMENT_KEY_NAME)
     );
+
+    // OrderBy
+    assertImplicitOrderBy(
+      query(
+        'foo',
+        filter('b', '<', 5),
+        filter('a', '>', 5),
+        filter('z', '>', 5),
+        orderBy('z')
+      ),
+      orderBy('z'),
+      orderBy('a'),
+      orderBy('b'),
+      orderBy(DOCUMENT_KEY_NAME)
+    );
+
+    // last explicit order by direction
+    assertImplicitOrderBy(
+      query(
+        'foo',
+        filter('b', '<', 5),
+        filter('a', '>', 5),
+        orderBy('z', 'desc')
+      ),
+      orderBy('z', 'desc'),
+      orderBy('a', 'desc'),
+      orderBy('b', 'desc'),
+      orderBy(DOCUMENT_KEY_NAME, 'desc')
+    );
+
+    assertImplicitOrderBy(
+      query(
+        'foo',
+        filter('b', '<', 5),
+        filter('a', '>', 5),
+        orderBy('z', 'desc'),
+        orderBy('c')
+      ),
+      orderBy('z', 'desc'),
+      orderBy('c'),
+      orderBy('a'),
+      orderBy('b'),
+      orderBy(DOCUMENT_KEY_NAME)
+    );
   });
 
   it('matchesAllDocuments() considers filters, orders and bounds', () => {