Remove prototype overrides in FirebaseError and all subclasses
#8552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make memory lru gc the default * undo yarn.lock * Make memory lru gc the default * Fix tests
Our v11 release will require node 18+. Since fetch has been introduced in these node versions, we can remove our dependency on third party fetch implementations. This change removes our usage of fetch variants undici and node-fetch for our node target builds and our CI tools.
With the removal of fetch we no long need to create a node bundle for functions. Instead the sourcebase may become isomorphic, so long as we remove the older node sources. And that's what the PR does!
dlarocque
requested review from
a team,
lisajian,
Xiaoshouzi-gh,
sam-gc,
maneesht and
tonyjhuang
as code owners
🦋 Changeset detectedLatest commit: 117527e The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (158,183 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
hsubox76
requested review from
erikeldridge,
jposuna,
avolkovi and
yoyomyo
as code owners
hsubox76
requested review from
yuchenshi,
zwu52 and
aashishpatil-g
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We override the prototype of
thisin all of the constructors for our custom error classes. This allowed us to adjust the prototype chain, so that we can performinstanceofchecks on subclasses ofError.Since ES2015, the built-in
Errorconstructor usesnew.targetto adjust the prototype chain for us, so we no longer need to do it ourselves.See https://github.com/Microsoft/TypeScript-wiki/blob/main/Breaking-Changes.md#extending-built-ins-like-error-array-and-map-may-no-longer-work (the link doesn't work well since the linked header is hidden behind a rolled up section that can be expanded by clicking "See Changes for Older Releases" at the bottom).
Since
new.targetdoes not exist in ES5, the prototype chain won't be adjusted if our bundle is transpiled down to ES5.