Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markduckworth/ppl #8578

Closed
wants to merge 19 commits into from
Closed

Markduckworth/ppl #8578

wants to merge 19 commits into from

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: fd20eff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 16, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (caf3090)Merge (f880a0a)Diff
    browser381 kB414 kB+32.6 kB (+8.5%)
    main588 kB644 kB+55.7 kB (+9.5%)
    module381 kB414 kB+32.6 kB (+8.5%)
    react-native382 kB414 kB+32.6 kB (+8.5%)
  • @firebase/firestore-lite

    TypeBase (caf3090)Merge (f880a0a)Diff
    browser111 kB143 kB+31.9 kB (+28.7%)
    main153 kB204 kB+51.5 kB (+33.7%)
    module111 kB143 kB+31.9 kB (+28.7%)
    react-native111 kB143 kB+31.9 kB (+28.7%)
  • bundle

    16 size changes

    TypeBase (caf3090)Merge (f880a0a)Diff
    firestore (CSI Auto Indexing Disable and Delete)272 kB302 kB+30.0 kB (+11.0%)
    firestore (CSI Auto Indexing Enable)272 kB302 kB+30.0 kB (+11.0%)
    firestore (Persistence)303 kB333 kB+29.8 kB (+9.8%)
    firestore (Pipeline Query with lt filter)?146 kB? (?)
    firestore (Query Cursors)249 kB269 kB+20.3 kB (+8.2%)
    firestore (Query)247 kB267 kB+20.3 kB (+8.2%)
    firestore (Read data once)234 kB259 kB+24.7 kB (+10.5%)
    firestore (Read Write w Persistence)328 kB348 kB+20.2 kB (+6.2%)
    firestore (Realtime updates)237 kB261 kB+24.7 kB (+10.4%)
    firestore (Transaction)214 kB234 kB+20.2 kB (+9.4%)
    firestore (Write data)213 kB236 kB+22.6 kB (+10.6%)
    firestore-lite (Query Cursors)91.4 kB111 kB+19.8 kB (+21.6%)
    firestore-lite (Query)87.6 kB107 kB+19.8 kB (+22.6%)
    firestore-lite (Read data once)63.0 kB87.8 kB+24.7 kB (+39.2%)
    firestore-lite (Transaction)88.3 kB108 kB+19.7 kB (+22.3%)
    firestore-lite (Write data)72.6 kB95.5 kB+22.8 kB (+31.4%)

  • firebase

    TypeBase (caf3090)Merge (f880a0a)Diff
    firebase-compat.js794 kB814 kB+20.0 kB (+2.5%)
    firebase-firestore-compat.js346 kB366 kB+20.0 kB (+5.8%)
    firebase-firestore-lite.js119 kB151 kB+31.8 kB (+26.8%)
    firebase-firestore.js440 kB473 kB+32.5 kB (+7.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7ueMXfE5nR.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 16, 2024

Size Analysis Report 1

This report is too large (3,204,378 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CYKSThTL5m.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants