More performant handling of out of order updates.

[MarkDuckworth]

If multiple queries receive updates to the same doc in the same global snapshot, watch does not guarantee the order of results received. Newer document versions may be received for one query before older document versions for another query. In some conditions, a newer document snapshot version could be overwritten by an older document snapshot version in the watch change aggregator. In the test scenario, stale document data is raised in a fromCache snapshot, and then the correct results were raised after a limbo resolution.

This PR provides a simple fix in the watch change aggregator where it will always accept the newest document snapshot if multiple versions are received.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2ae7e16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Size Report ¹

Affected Products

• @firebase/firestore

  Type	Base (91fa315)	Merge (6194fd7)	Diff
  browser	381 kB	382 kB	+148 B (+0.0%)
  main	588 kB	588 kB	+335 B (+0.1%)
  module	381 kB	382 kB	+148 B (+0.0%)
  react-native	382 kB	382 kB	+148 B (+0.0%)

• bundle

  Type	Base (91fa315)	Merge (6194fd7)	Diff
  firestore (Persistence)	303 kB	304 kB	+148 B (+0.0%)
  firestore (Query Cursors)	249 kB	249 kB	+148 B (+0.1%)
  firestore (Query)	247 kB	247 kB	+148 B (+0.1%)
  firestore (Read data once)	234 kB	234 kB	+148 B (+0.1%)
  firestore (Read Write w Persistence)	328 kB	328 kB	+148 B (+0.0%)
  firestore (Realtime updates)	237 kB	237 kB	+148 B (+0.1%)

• firebase

  Type	Base (91fa315)	Merge (6194fd7)	Diff
  firebase-compat.js	794 kB	795 kB	+142 B (+0.0%)
  firebase-firestore-compat.js	346 kB	347 kB	+142 B (+0.0%)
  firebase-firestore.js	440 kB	440 kB	+148 B (+0.0%)

Test Logs

• Base (91fa315): https://github.com/firebase/firebase-js-sdk/actions/runs/11524251114
• Merge (6194fd7): https://github.com/firebase/firebase-js-sdk/actions/runs/11525313745

1. https://storage.googleapis.com/firebase-sdk-metric-reports/7U6EITLZMY.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

• @firebase/firestore

  • enableMultiTabIndexedDbPersistence

    Size

    Type	Base (91fa315)	Merge (6194fd7)	Diff
    size	223 kB	223 kB	+148 B (+0.1%)
    size-with-ext-deps	295 kB	295 kB	+148 B (+0.1%)

  • getDoc

    Size

    Type	Base (91fa315)	Merge (6194fd7)	Diff
    size	153 kB	153 kB	+148 B (+0.1%)
    size-with-ext-deps	225 kB	225 kB	+148 B (+0.1%)

  • getDocFromServer

    Size

    Type	Base (91fa315)	Merge (6194fd7)	Diff
    size	153 kB	153 kB	+148 B (+0.1%)
    size-with-ext-deps	225 kB	225 kB	+148 B (+0.1%)

  • getDocs

    Size

    Type	Base (91fa315)	Merge (6194fd7)	Diff
    size	155 kB	155 kB	+148 B (+0.1%)
    size-with-ext-deps	227 kB	227 kB	+148 B (+0.1%)

  • getDocsFromServer

    Size

    Type	Base (91fa315)	Merge (6194fd7)	Diff
    size	155 kB	155 kB	+148 B (+0.1%)
    size-with-ext-deps	226 kB	227 kB	+148 B (+0.1%)

  • onSnapshot

    Size

    Type	Base (91fa315)	Merge (6194fd7)	Diff
    size	155 kB	155 kB	+148 B (+0.1%)
    size-with-ext-deps	227 kB	227 kB	+148 B (+0.1%)

  • onSnapshotsInSync

    Size

    Type	Base (91fa315)	Merge (6194fd7)	Diff
    size	144 kB	144 kB	+148 B (+0.1%)
    size-with-ext-deps	216 kB	216 kB	+148 B (+0.1%)

  • persistentMultipleTabManager

    Size

    Type	Base (91fa315)	Merge (6194fd7)	Diff
    size	218 kB	219 kB	+148 B (+0.1%)
    size-with-ext-deps	290 kB	291 kB	+148 B (+0.1%)

Test Logs

• Base (91fa315): https://github.com/firebase/firebase-js-sdk/actions/runs/11524251114
• Merge (6194fd7): https://github.com/firebase/firebase-js-sdk/actions/runs/11525313745

1. https://storage.googleapis.com/firebase-sdk-metric-reports/eqavd7aB32.html

[dconeybe]

LGTM. Nice fix! Please add a changeset though. Also, please make sure these tests and fixes get ported to android and ios (whether you do the porting or someone else does).