-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support streaming streaming responses for callable functions. #8609
Draft
taeold
wants to merge
22
commits into
main
Choose a base branch
from
dl-fn-streaming
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+663
−35
Draft
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
48eca40
Support streaming streaming responses for callable functions.
taeold 21db516
Merge branch 'main' into dl-fn-streaming
taeold d28863c
Support AbortSignal
taeold a02b25f
Update API reports
taeold ab99970
Re-introduce fetchImpl.
taeold 8ec2787
Merge branch 'dl-fn-streaming' of https://github.com/firebase/firebas…
taeold 4aee03e
Add more tests.
taeold fdc70d8
Update API reports
taeold 55d9266
Add comment.
taeold 9a430cc
Merge branch 'dl-fn-streaming' of https://github.com/firebase/firebas…
taeold 785e906
Allow reading multiple data chunks from single read() chunk.
taeold 861edce
Fix lint errors.
taeold 4b188d0
Don't swallow errors.
taeold 39c44d5
Fix linter issues.
taeold 1c1f533
Update API reports
taeold b481220
Merge remote-tracking branch 'origin/main' into dl-fn-streaming
taeold 9f4c973
Merge branch 'dl-fn-streaming' of https://github.com/firebase/firebas…
taeold ebd74cb
Add changeset.
taeold cf56623
Update code to use pump() patter.
taeold cfbcd46
Refactor implementation for better readability.
taeold 1801c53
Nits.
taeold bf4f5e9
More nits.
taeold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,8 @@ | |
"test:browser": "karma start", | ||
"test:browser:debug": "karma start --browsers=Chrome --auto-watch", | ||
"test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'src/{,!(browser)/**/}*.test.ts' --file src/index.ts --config ../../config/mocharc.node.js", | ||
"test:emulator": "env FIREBASE_FUNCTIONS_EMULATOR_ORIGIN=http://localhost:5005 run-p --npm-path npm test:node", | ||
"test:emulator": "env FIREBASE_FUNCTIONS_EMULATOR_ORIGIN=http://127.0.0.1:5005 run-p test:node", | ||
"test:emulator": "env FIREBASE_FUNCTIONS_EMULATOR_ORIGIN=http://127.0.0.1:5005 run-p --npm-path npm test:node", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is my github diff wonky or are these two lines with the same script name? |
||
"trusted-type-check": "tsec -p tsconfig.json --noEmit", | ||
"api-report": "api-extractor run --local --verbose", | ||
"doc": "api-documenter markdown --input temp --output docs", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we actually need to touch
functions-types
- these-types
packages are normally used only for compat. Sometimes the modular packages do import from the types packages but it doesn't look like functions does.