Apphosting emulator: Clean up secrets when writing to apphosting.loca…

…l.yaml (#7964)

src/apphosting/config.ts

@@ -242,8 +242,9 @@ export async function exportConfig(
     });
   }
 
-  // update apphosting.local.yaml
-  await localAppHostingConfig.upsertFile(localAppHostingConfigPath);
+  // remove secrets to avoid confusion as they are not read anyways.
+  localAppHostingConfig.clearSecrets();
+  localAppHostingConfig.upsertFile(localAppHostingConfigPath);
   logger.info(`Wrote secrets as environment variables to ${APPHOSTING_LOCAL_YAML_FILE}.`);
 
   updateOrCreateGitignore(projectRoot, [APPHOSTING_LOCAL_YAML_FILE]);

src/apphosting/yaml.spec.ts

@@ -96,6 +96,21 @@ describe("yaml", () => {
         JSON.stringify([{ variable: "TEST", secret: "overwritten_value" }]),
       );
     });
+
+    it("should clear secrets when clearSecrets is called", () => {
+      apphostingYaml.addSecret({
+        variable: "TEST",
+        secret: "value",
+      });
+
+      apphostingYaml.addSecret({
+        variable: "TEST",
+        secret: "overwritten_value",
+      });
+
+      apphostingYaml.clearSecrets();
+      expect(JSON.stringify(apphostingYaml.secrets)).to.equal(JSON.stringify([]));
+    });
   });
 
   describe("merge", () => {

src/apphosting/yaml.ts

@@ -69,6 +69,10 @@ export class AppHostingYamlConfig {
     this._secrets.set(secret.variable, secret);
   }
 
+  clearSecrets() {
+    this._secrets.clear();
+  }
+
   /**
    * Merges this AppHostingYamlConfig with another config, the incoming config
    * has precedence if there are any conflicting configurations.