Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to add/link new provider to the account results in 501 #4170

Open
Junaid-Ahm opened this issue Feb 16, 2022 · 11 comments · May be fixed by #7980
Open

Request to add/link new provider to the account results in 501 #4170

Junaid-Ahm opened this issue Feb 16, 2022 · 11 comments · May be fixed by #7980
Assignees
@yuchenshi
Labels
emulator-suite emulators: auth help-wanted internal-bug-filed type: feature request

Comments

@Junaid-Ahm
Copy link

Junaid-Ahm commented Feb 16, 2022 •
edited
Loading

[REQUIRED] Environment info

firebase-tools: 10.20.0

Platform: Ubuntu 20.04 x86_64

[REQUIRED] Test case

This issue is only happening in emulator. Works fine with actual firebase project.

{
  "error": {
    "code": 501,
    "message": "linkProviderUserInfo is not implemented yet.",
    "errors": [
      {
        "message": "linkProviderUserInfo is not implemented yet.",
        "reason": "unimplemented"
      }
    ],
    "status": "NOT_IMPLEMENTED"
  }
}

[REQUIRED] Steps to reproduce

  1. Create an account in emulator (eg via firebase admin SDK's create user)
  2. Attempt to add/link new provider to the existing account via update user (eg via firebase admin SDK's update user), which makes the POST request to endpoint /accounts:update results in the above error.

[REQUIRED] Expected behaviour

Should add/link the provider info to the account.

[REQUIRED] Actual behaviour

Returns error with above error message.
@Junaid-Ahm Junaid-Ahm added the bug label Feb 16, 2022
@yuchenshi
Copy link
Member

yuchenshi commented Mar 1, 2022 •
edited
Loading

Hi, thanks for filing this issue! We are unable to promise any timeline for this, but if others also have this issue, adding a +1 on this issue can help us prioritize adding this to the roadmap.

(Googler-only internal tracking bug: b/222142440)

@yuchenshi
Copy link
Member

FYI, we're also accepting Pull Requests for this feature. A good place to start is

firebase-tools/src/emulator/auth/operations.ts

Line 977 in daa604a

"linkProviderUserInfo",

@Junaid-Ahm
Copy link
Author

@yuchenshi any plans for this?

@Junaid-Ahm
Copy link
Author

@prameshj Can you also please review this and raise an internal ping for a followup?

@prameshj
Copy link

@malcolmdeck

@Junaid-Ahm
Copy link
Author

@malcolmdeck Looking forward to your thoughts on this?

@christhompsongoogle
Copy link
Contributor

We're aware of the issue but don't have a timeline on a resolution.

@NateMay
Copy link

NateMay commented Mar 2, 2023

Are there any other mechanisms to seed users in the emulator with providers linked? I can't seem to set provided data with createUser() or updateUser() so my team is currently forced to manually link providers within the UI.

@Junaid-Ahm
Copy link
Author

@yuchenshi @christhompsongoogle @prameshj @joehan still waiting a timeline on this - opened in Feb'22

@christhompsongoogle
Copy link
Contributor

Thanks for following up, but I have no updates to share. The fastest way to get this resolved would be to try your hand at a fix via Yuchen's link above.

@paulrostorp paulrostorp mentioned this issue Aug 23, 2023
Open
@paulrostorp
Copy link

paulrostorp commented Aug 23, 2023 •
edited
Loading

I've implemented this as suggested by @yuchenshi in #6291.
I've published it to npm here as @paulrostorp/firebase-tools

@mohankumarelec mohankumarelec linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuchenshi yuchenshi

Labels
emulator-suite emulators: auth help-wanted internal-bug-filed type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated to fix issues-4170 mohankumarelec/firebase-tools
7 participants
@paulrostorp @joehan @NateMay @yuchenshi @prameshj @Junaid-Ahm @christhompsongoogle