Updated to fix issues-4170 #7980
Open
+105
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Needs a CHANGELOG entry before merge. |
yuchenshi
approved these changes
Nov 21, 2024
src/emulator/auth/operations.ts
Outdated
| @@ -1232,8 +1231,20 @@ export function setAccountInfoImpl( | |||
| } | |||
| } | |||
|
|
|||
| if (reqBody.linkProviderUserInfo) { | |||
| if (!reqBody.linkProviderUserInfo.providerId?.length) { | |||
| throw new Error("providerId is required and must be a non-empty string.") | |||
There was a problem hiding this comment.
These should use assert to throw a client error instead of internal error, but I don't know what the correct error codes should be. Maybe we can settle with assert(condition, "TODO_ERROR_CODE : missing providerId") for now
| .query({ key: "fake-api-key" }) | ||
| .send({ idToken, linkProviderUserInfo: incompleteProviderUserInfo2 }) | ||
| .catch((err) => { | ||
| expect(err.response.status).to.equal(500); // Expecting internal server error since it's a missing validation |
There was a problem hiding this comment.
As mentioned above, let's make this a 400
|
PTAL at the unit test failures and I can do another round of review after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #4170
This PR fixes the issue and adds feature of
linkProviderUserInfoin auth emulator.Scenarios Tested