Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize use.ts and stop requiring auth for use #7780

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Oct 2, 2024

Description

Modernized 'use.ts' to use async/await, and make firebase use work when not logged in. In cases where users don't actually have access to the project, they'll hit normal auth errors later when they execute commands, which is fine.

@joehan joehan requested review from yuchenshi and aalej October 2, 2024 19:53
@joehan joehan removed the request for review from yuchenshi October 8, 2024 17:49
Copy link
Contributor Author

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to fix the tests that this is breaking, no need to review yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants