Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type from number to integer for the emulator ports. #7953

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jfbenckhuijsen
Copy link

Description

Changed the firebase-config.json Schema file. The ports of the emulators are changed from number to integer. Main reason for this is when using the schema in a generator like jsonschema2pojo, the generator will generate java.lang.Double as field instead of java.lang.Integer. As ports can only be integers, this setup better reflects the field.

Copy link

google-cla bot commented Nov 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the gist of this change - however, this file is generated from the contents of src/firebaseConfig.ts by running npm run generate:json-schema. It shouldn't be edited manually (and our test suite will not pass if it is).

If you can find a way to change src/firebaseConfig.ts to get this outcome, go for it!

@jfbenckhuijsen
Copy link
Author

jfbenckhuijsen commented Nov 22, 2024

I agree with the gist of this change - however, this file is generated from the contents of src/firebaseConfig.ts by running npm run generate:json-schema. It shouldn't be edited manually (and our test suite will not pass if it is).

If you can find a way to change src/firebaseConfig.ts to get this outcome, go for it!

Looks like that should be doable with

/** @TJS-type integer */

Just a quick question, the UI field has a port specified as number | string. When would you specify a string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants