Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value for dataDir in init dataconnect #7989

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Nov 21, 2024

Description

Add default value for dataDir in init dataconnect, and makes it configurable via init emulators:dataconnect.

I intentionally held this back until post Thanksgiving freeze so that this persistence behavior is opt in for now.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.19%. Comparing base (a177fe0) to head (8468b5b).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
src/init/features/dataconnect/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7989      +/-   ##
==========================================
- Coverage   51.36%   51.19%   -0.18%     
==========================================
  Files         422      423       +1     
  Lines       29344    29542     +198     
  Branches     5996     6031      +35     
==========================================
+ Hits        15074    15125      +51     
- Misses      12915    13057     +142     
- Partials     1355     1360       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@joehan joehan requested a review from fredzqm November 21, 2024 23:52
src/init/features/dataconnect/index.ts Outdated Show resolved Hide resolved
src/emulator/initEmulators.ts Outdated Show resolved Hide resolved
@joehan joehan enabled auto-merge (squash) November 22, 2024 18:05
@joehan joehan merged commit 49c5ac5 into master Nov 22, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants