Fixed onDisconnect logic to use deviceId #1010
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maneesht
commented
Aug 30, 2022
| // ... and write it to Firestore. | ||
| await userStatusFirestoreRef.delete(); | ||
|
|
||
| if ((await userDeviceCollectionRef.get()).empty) { |
There was a problem hiding this comment.
async/await syntax targets ES2016+, which is inconsistent with the rest of the file. Looking for whether ES5 is the target, or ES2016+
jsdt
reviewed
Aug 30, 2022
presence-firestore/public/index.js
Outdated
| @@ -21,7 +21,8 @@ function rtdb_presence() { | |||
|
|
|||
| // Create a reference to this user's specific status node. | |||
| // This is where we will store data about being online/offline. | |||
| var userStatusDatabaseRef = firebase.database().ref('/status/' + uid); | |||
| // `push()` will add a new key to the user's path, acting as a deviceId | |||
| var deviceStatusDatabaseRef = firebase.database().ref('/status/' + uid + '/devices').push(); | |||
There was a problem hiding this comment.
sessions or connections is probably more accurate than devices, since the id isn't based on the device id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example originally used
uiddocuments to determine whether a user is online or not. This is not best practice because you may have an onDisconnect that sets the user as offline, and if the same user open two different tabs, close one tab, and the user would show up as offline, even though one tab is still open.This PR adds a
devicescollection and then adds a new document that represents the device's ID, and onDisconnect, will set the device's status to offline. The coThe function will check that change and remove the device from the Firestore user's devices collection and check if there are no devices in the collection. If that is the case, then the user itself will be removed from the user collection.The client will then check Firestore for how many users are in the users collection.