[GO] allow multiple types in jsonschema #1221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We want to fix these tests here (currently skipped because they fail): |
alonsopec89
changed the title
apascal07
reviewed
Nov 15, 2024
| @@ -95,3 +96,5 @@ require ( | |||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20240708141625-4ad9e859172b // indirect | |||
| google.golang.org/grpc v1.65.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/invopop/jsonschema => github.com/alonsopf/jsonschema v0.0.0-20241112034953-8a224be9076f | |||
There was a problem hiding this comment.
Revert? Or are you actually relying on changes in your fork?
There was a problem hiding this comment.
I actually relying on changes in my fork to support multiple types
There was a problem hiding this comment.
Ah, that's no good. We don't want to rely on a fork of this, it's not sustainable for us to maintain it. Is there any way to roll those changes into the Genkit library? Otherwise we need to explore a different solution.
There was a problem hiding this comment.
I opened a PR in the jsonschema repo, also I'm reviewing anothers options if doesn't get merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding support for multiple_types here: invopop/jsonschema@main...alonsopf:jsonschema:main
Checklist (if applicable):