fix: @invertase update basic-gemini app for compatibility with new dependencies #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustolandia
added
bug
Gustolandia
changed the title
Gustolandia
force-pushed
the
@invertase/genkit/js/testapps/basic-gemini
branch
3 times, most recently
from
46c49b3
to
cab9b08
Compare
Gustolandia
force-pushed
the
@invertase/genkit/js/testapps/basic-gemini
branch
from
cab9b08
to
ed9ef10
Compare
pavelgj
reviewed
Nov 15, 2024
| @@ -7,20 +7,23 @@ | |||
| "test": "echo \"Error: no test specified\" && exit 1", | |||
| "start": "node lib/index.js", | |||
| "build": "tsc", | |||
| "build:watch": "tsc --watch" | |||
| "build:watch": "tsc --watch", | |||
| "genkit:dev": "cross-env GENKIT_ENV=dev pnpm dev", | |||
There was a problem hiding this comment.
same thing as in #1259 (comment)
pavelgj
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the following changes to ensure the functionality and maintainability of the basic-gemini app:
Code Fixes: Updated the core logic to resolve compatibility issues with the latest dependencies, including @genkit-ai/googleai and @genkit-ai/vertexai. Adjusted input handling and flow definitions for jokeFlow and jokeSubjectGenerator tools.
Dependencies: Updated package.json to include necessary dependencies and reflect the workspace structure.
Documentation: Added a detailed README.md file with setup instructions, usage guidelines, and examples for both developers and testers.
Changes Made:
Corrected the jokeFlow logic to handle user inputs via UI.
Fixed LLM response parsing to align with updated API expectations.
Enhanced comments and structure within the main code for clarity.
Added environment setup instructions (including API key and Google Cloud configuration) to README.md.
Testing:
Verified the app locally with pnpm genkit:dev and genkit flow:run jokeFlow.
Ensured seamless interaction with the Genkit Developer UI for user inputs and outputs.
Impact:
This update resolves compatibility issues caused by recent dependency changes and improves documentation, making the basic-gemini app more accessible to new developers and testers.
Checklist (if applicable):