feat: add Context Caching to Gemini plugins #1297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cabljac
force-pushed
the
@invertase/context-caching-0.9
branch
from
1421561
to
87b0185
Compare
cabljac
changed the title
cabljac
changed the title
docs(js/plugins/googleai): document context caching
cabljac
force-pushed
the
@invertase/context-caching-0.9
branch
from
87b0185
to
7f44d4c
Compare
cabljac
force-pushed
the
@invertase/context-caching-0.9
branch
from
b7a621b
to
6106b6f
Compare
|
Should wait for this fix: |
cabljac
force-pushed
the
@invertase/context-caching-0.9
branch
from
6106b6f
to
754f8f1
Compare
cabljac
commented
Nov 20, 2024
| ) => { | ||
| return fromGeminiCandidate(candidate, jsonMode); | ||
| }; | ||
| let cache: CachedContent | null = null; |
cabljac
commented
Nov 20, 2024
| }; | ||
| let cache: CachedContent | null = null; | ||
|
|
||
| // TODO: fix casting |
cabljac
commented
Nov 20, 2024
| cache = handleContextCacheResponse.cache; | ||
| } | ||
|
|
||
| let genModel: GenerativeModel | null = null; |
cabljac
commented
Nov 20, 2024
| request: any, | ||
| modelVersion: string | ||
| ): boolean { | ||
| if (!modelVersion || !CONTEXT_CACHE_SUPPORTED_MODELS.includes(modelVersion)) { |
There was a problem hiding this comment.
this probably shouldn't throw - we should probably just return false
There was a problem hiding this comment.
It should probably throw if they try to use cache (cache is in metadata etc) but the model version is wrong. We don't want to accidentally cost them lots of tokens.
cabljac
commented
Nov 20, 2024
| /** | ||
| * Clears all caches using the cache manager. | ||
| */ | ||
| export async function clearAllCaches( |
There was a problem hiding this comment.
this isnt actually used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Checklist (if applicable):