fix(cli): fixed runtime metadata filename not being valid (special characters) for all platforms #1322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should solve the issue #1318.
I have noticed that in the latest version of Genkit (0.9.X), the filename of runtime follows the format
${process.pid}-${timestamp}.json
as in the writeRuntimeFile(). However, the produced filename is not a valid name on Windows due to the timestamp part which contains reserved characters such as ":".What happens next is that when you try to run any kind of script using genkit library, the runtime file won't be generated due to
invalid filename: "Error writing runtime file: Error: ENOENT: no such file or directory, open '.genkit\runtimes\42744-2024-11-18T12:17:25.549Z.json'
As I don't know exactly the purpose of the ISO format in the filename, I've replaced that format with the milliseconds.
Checklist (if applicable):