Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appdistribution): add in-app-feedback support #1463
base: master
Are you sure you want to change the base?
feat(appdistribution): add in-app-feedback support #1463
Changes from 4 commits
197a062
ca654a8
e9cc93b
c142c9f
73141ba
2940487
9ea2ed6
8ba8dab
b22860c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need this anymore now that we made the change to automatically hide the notification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When does the automatic hide take place? I tried closing the Activity, but it didn't dismiss the notification. Is it when the app is closed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you want this check here anymore. Even if they are on an older device we still want to show the notification. On older devices the
checkSelfPermission()
call will returntrue
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc: @marinacoelho
The check is due to the
POST_NOTIFICATIONS
field which was introduced in API 33.I have added an else branch to display the feedback notification on older devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Lee's comment above, I think we don't need this line here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as Lee's comment above. And if we absolutely need to keep this check here, what do you think of changing this function a bit to use
when
instead ofif
/else if
/else
? (Orswitch
/case
on the Java file).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a
when
here might work for Kotlin, since the language allows usage ofwhen
without a subject. But not sure if Java has a switch-case without a subject 🤔