Add OR snippets #430
Open
Add OR snippets #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsannas
reviewed
Mar 4, 2023
firestore/app/src/main/java/com/google/example/firestore/DocSnippets.java
Show resolved
Hide resolved
| collection.where(Filter.or( | ||
| Filter.inArray("a", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)), | ||
| Filter.inArray("b", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)), | ||
| )); |
There was a problem hiding this comment.
Unfortunately there's currently a bug in the backend which prevents this query from being served -- Even though it is a valid query (it's valid to have one IN operator per disjunction).
There was a problem hiding this comment.
We can add this to the snippet registry and then exclude it from devsite for now.
1shaperformance
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.