Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing keyword await fixed issue #330 #345

Closed

Conversation

priyanshuverma-dev
Copy link

fixed issue #330
The docs related to Set a document see here are missing the keyword await before setDoc() function.
For the code example where the { merge: true} is used.

@google-cla
Copy link

google-cla bot commented May 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @AntrikshVerma! Once you make the requested change, we can merge this.

snippets/firestore-next/test-firestore/set_with_merge.js Outdated Show resolved Hide resolved
Antriksh Verma and others added 3 commits June 1, 2023 20:59
@thatfiredev
Copy link
Member

@priyanshuverma-dev it seems like you may have committed with multiple emails which have not signed the CLA, and that's what's causing the CLA check to fail. Can you take a look?

An easier alternative would be to open a new PR and only commit with the email that has signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants