Generify docker container to not hardcode /firecracker paths
#4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utilifies -> utilities (e.g. replace the 'f' with a 't'). Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Used to run cargo-afl based fuzzers. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Remove all hardcoded paths that start with /firecracker from the docker container such that it can be used outside of the firecracker repository. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
bump the devctr version from v73 to v74 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4714 +/- ##
==========================================
- Coverage 82.85% 81.97% -0.88%
==========================================
Files 254 254
Lines 30807 31169 +362
==========================================
+ Hits 25524 25552 +28
- Misses 5283 5617 +334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
added
the
Status: Awaiting review
kalyazin
approved these changes
Aug 1, 2024
bchalios
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docker container to not hardcode
/firecrackeras the root of all paths. Instead, use the--workdiroption. Also use--volumeinstead of symlinks inside of the dockerfile to point the cargo registry towardfirecracker/build/cargo_{git_registry,registry}. This is needed because we want to use this docker container to run fuzzers which we keep in a different (private) repository.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.