Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tap): use corrent virtio feature for CSUM offload #4725

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

ihciah
Copy link
Contributor

@ihciah ihciah commented Aug 11, 2024

Changes

Enable TUN_F_CSUM when VIRTIO_NET_F_GUEST_CSUM is negotiated.

Reason

Enable TUN_F_CSUM for TAP device means it's user(which is VMM) can handle partially checksumed packets. Since we deliver the data directly from tap to guest, so it becomes a requirement for the driver.

QEMU's implementation:

Cloud-hypervisor's:

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@bchalios
Copy link
Contributor

Hi @ihciah,

Thanks for your contribution! Could you please solve the style issues in the PR, following this: https://github.com/firecracker-microvm/firecracker/blob/main/CONTRIBUTING.md#contribution-quality-standards?

I think what's missing is a body in your commit message.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (a46d1b9) to head (fd1b77a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4725   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files         249      249           
  Lines       27433    27433           
=======================================
  Hits        23147    23147           
  Misses       4286     4286           
Flag Coverage Δ
5.10-c5n.metal ?
5.10-m5n.metal 84.58% <100.00%> (?)
5.10-m6a.metal 83.87% <100.00%> (-0.01%) ⬇️
5.10-m6g.metal 80.91% <100.00%> (?)
5.10-m6i.metal 84.58% <100.00%> (?)
5.10-m7g.metal 80.91% <100.00%> (ø)
6.1-c5n.metal 84.59% <100.00%> (-0.01%) ⬇️
6.1-m5n.metal 84.58% <100.00%> (ø)
6.1-m6a.metal 83.88% <100.00%> (+<0.01%) ⬆️
6.1-m6i.metal 84.58% <100.00%> (ø)
6.1-m7g.metal 80.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enable TUN_F_CSUM based on whether VIRTIO_NET_F_GUEST_CSUM is
negotiated.

Signed-off-by: ihciah <ihciah@gmail.com>
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Aug 14, 2024
@roypat roypat merged commit a364da8 into firecracker-microvm:main Aug 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants