-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action workflow #25
Open
fiskenslakt
wants to merge
1
commit into
main
Choose a base branch
from
add-github-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
--- | ||
name: Ruff Lint and Format check in PR Python files | ||
description: Checks the lint and formatting only on **changed python files in PR** or even single commits in your repo | ||
branding: | ||
icon: 'check-square' | ||
color: 'green' | ||
runs: | ||
using: composite | ||
steps: | ||
- name: Install Ruff | ||
run: pip install ruff | ||
shell: bash | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not needed |
||
|
||
- name: Get PR changes | ||
id: get_py_files | ||
uses: tj-actions/changed-files@v41 | ||
with: | ||
files: "**.py" | ||
|
||
- name: Check Python format using Ruff on changed files | ||
id: adi658_ruff_format_check | ||
continue-on-error: true | ||
run: | | ||
echo "Python files changed in PR: ${{ | ||
steps.get_py_files.outputs.all_changed_files }}" | ||
|
||
if [ ! -z "${{ steps.get_py_files.outputs.all_changed_files }}" ] | ||
then | ||
ruff format --check ${{ steps.get_py_files.outputs.all_changed_files }} | ||
else | ||
echo "No python files changed in PR" | ||
fi | ||
shell: bash | ||
|
||
- name: Check Python Lint using Ruff on changed files | ||
id: adi658_ruff_lint_check | ||
continue-on-error: true | ||
run: | | ||
echo "Python files changed in PR: ${{ | ||
steps.get_py_files.outputs.all_changed_files }}" | ||
|
||
if [ ! -z "${{ steps.get_py_files.outputs.all_changed_files }}" ] | ||
then | ||
ruff check ${{ inputs.ruff_args }} ${{ steps.get_py_files.outputs.all_changed_files }} | ||
else | ||
echo "No python files changed in PR" | ||
fi | ||
shell: bash | ||
|
||
- name: Format and Lint check Status | ||
run: | | ||
if [[ "${{ steps.adi658_ruff_format_check.outcome }}" == "success" && "${{ steps.adi658_ruff_lint_check.outcome }}" == success ]]; then | ||
echo "" | ||
echo "Lint and Format check on changed python files succeeded" | ||
echo "" | ||
else | ||
echo "" | ||
echo "***** Lint/Format Checks on changed python files failed" | ||
echo "***** Ruff Format check result: ${{ steps.adi658_ruff_format_check.outcome }}" | ||
echo "***** Ruff Lint check result: ${{ steps.adi658_ruff_lint_check.outcome }}" | ||
echo "" | ||
echo "You can auto resolve any formatting issues using 'ruff format <foldername/or/space_separated_filenames>'. Pls make sure you check/test the code after auto-format" | ||
echo "You can auto resolve any lint issues using 'ruff check <foldername/or/space_separated_filenames> --fix'. Pls make sure you check/test/format the code after auto-lint fix" | ||
exit 1 | ||
fi | ||
shell: bash |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why