fix: basicspage broken when no displayname drivers enabled (#4062)

flarum · Oct 8, 2024 · c737d7b · c737d7b
1 parent 9295e7b
commit c737d7b
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/framework/core/js/src/admin/components/BasicsPage.tsx b/framework/core/js/src/admin/components/BasicsPage.tsx
@@ -89,9 +89,9 @@ export default class BasicsPage<CustomAttrs extends IPageAttrs = IPageAttrs> ext
       90
     );
 
-    items.add(
-      'default-locale',
-      Object.keys(this.localeOptions).length > 1 && (
+    Object.keys(this.localeOptions).length > 1 &&
+      items.add(
+        'default-locale',
         <>
           {this.buildSettingComponent({
             type: 'select',
@@ -104,10 +104,9 @@ export default class BasicsPage<CustomAttrs extends IPageAttrs = IPageAttrs> ext
             setting: 'show_language_selector',
             label: app.translator.trans('core.admin.basics.show_language_selector_label'),
           })}
-        </>
-      ),
-      80
-    );
+        </>,
+        80
+      );
 
     items.add(
       'home-page',
@@ -136,18 +135,19 @@ export default class BasicsPage<CustomAttrs extends IPageAttrs = IPageAttrs> ext
       60
     );
 
-    items.add(
-      'display-name-driver',
-      Object.keys(this.displayNameOptions).length > 1 &&
+    Object.keys(this.displayNameOptions).length > 1 &&
+      items.add(
+        'display-name-driver',
+
         this.buildSettingComponent({
           type: 'select',
           setting: 'display_name_driver',
           options: this.displayNameOptions,
           label: app.translator.trans('core.admin.basics.display_name_heading'),
           help: app.translator.trans('core.admin.basics.display_name_text'),
         }),
-      50
-    );
+        50
+      );
 
     items.add(
       'slug-driver',