Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix(core, mentions): return null if content left empty in formatter #4059

Merged
merged 11 commits into from
Oct 8, 2024

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Oct 7, 2024

Fixes #3983

Changes proposed in this pull request:

  • Return null instead of void if content field left empty while creating new discussion
  • Remove typings from mentions Unparser and change type annotation to mixed
  • Implement test to cover the exact case that was described in the linked issue

Reviewers should focus on:

  • Is this change backwards compatible? Might bis break third-party extensions which used workarounds to fix this issue?
  • Will PR 2.x in the next coming days for the same fix

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title test(core): implement test for empty content [1.x] fix(core): return null if content left empty on new discussion Oct 7, 2024
@DavideIadeluca DavideIadeluca changed the title [1.x] fix(core): return null if content left empty on new discussion [1.x] fix(core): return null if content left empty in new discussion Oct 7, 2024
@DavideIadeluca DavideIadeluca force-pushed the di/empty-post-content-fix branch 2 times, most recently from c1d01e2 to ded30ae Compare October 7, 2024 15:43
@DavideIadeluca DavideIadeluca force-pushed the di/empty-post-content-fix branch from ded30ae to 6d1c8b3 Compare October 7, 2024 15:44
@DavideIadeluca DavideIadeluca marked this pull request as ready for review October 7, 2024 15:57
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner October 7, 2024 15:57
@DavideIadeluca DavideIadeluca force-pushed the di/empty-post-content-fix branch from fbe83e8 to 20c292c Compare October 7, 2024 16:01
@DavideIadeluca DavideIadeluca changed the title [1.x] fix(core): return null if content left empty in new discussion [1.x] fix(core, mentions): return null if content left empty in new discussion Oct 7, 2024
@DavideIadeluca DavideIadeluca changed the title [1.x] fix(core, mentions): return null if content left empty in new discussion [1.x] fix(core, mentions): return null if content left empty in formatter Oct 8, 2024
@imorland imorland added this to the 1.8.6 milestone Oct 8, 2024
@imorland imorland merged commit 9c91c89 into flarum:1.x Oct 8, 2024
274 checks passed
@imorland imorland deleted the di/empty-post-content-fix branch October 8, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants