-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] fix(core, mentions): return null if content left empty in formatter #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideIadeluca
changed the title
test(core): implement test for empty content
[1.x] fix(core): return null if content left empty on new discussion
Oct 7, 2024
DavideIadeluca
changed the title
[1.x] fix(core): return null if content left empty on new discussion
[1.x] fix(core): return null if content left empty in new discussion
Oct 7, 2024
DavideIadeluca
force-pushed
the
di/empty-post-content-fix
branch
2 times, most recently
from
October 7, 2024 15:43
c1d01e2
to
ded30ae
Compare
DavideIadeluca
force-pushed
the
di/empty-post-content-fix
branch
from
October 7, 2024 15:44
ded30ae
to
6d1c8b3
Compare
DavideIadeluca
force-pushed
the
di/empty-post-content-fix
branch
from
October 7, 2024 16:01
fbe83e8
to
20c292c
Compare
DavideIadeluca
changed the title
[1.x] fix(core): return null if content left empty in new discussion
[1.x] fix(core, mentions): return null if content left empty in new discussion
Oct 7, 2024
DavideIadeluca
changed the title
[1.x] fix(core, mentions): return null if content left empty in new discussion
[1.x] fix(core, mentions): return null if content left empty in formatter
Oct 8, 2024
imorland
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3983
Changes proposed in this pull request:
null
instead ofvoid
if content field left empty while creating new discussionmixed
Reviewers should focus on:
Screenshot
QA
Necessity
Confirmed
composer test
).Required changes: