Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libportal: Add activation-token to notification-action-invoked #88

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

libportal: Add activation-token to notification-action-invoked #88

wants to merge 5 commits into from

Commits on May 6, 2022

  1. notification: Remove unused variable

    @3v1n0
    3v1n0 committed May 6, 2022
    Configuration menu
    Copy the full SHA
    eef133c View commit details
    Browse the repository at this point in the history

  2. notification: Use GTask to handle callback data 

    Use cleaner way to handle callback data in case one is provided, making
it easier to handle if we need to chain more calls
    @3v1n0
    3v1n0 committed May 6, 2022
    Configuration menu
    Copy the full SHA
    bf75229 View commit details
    Browse the repository at this point in the history

  3. libportal: Add activation-token to notification-action-invoked 

    Since some time FDO Notifications introduced the ActivationToken signal
to ensure that clients will receive an X11-startup notification ID or a
wayland xdg-activation token in order to support stealing-focus
prevention protocols.

However this isn't supported by xdg-desktop-portal's.
So fill the gap by adding a further activation token.

While it could be added by as an optional parameter, it's just better to
make it explicit.

At the same time, let's bump the library version as the signal signature
changed (while adding a new one with an extra parameter looked overkill.
    @3v1n0
    3v1n0 committed May 6, 2022
    Configuration menu
    Copy the full SHA
    37ceaba View commit details
    Browse the repository at this point in the history

  4. CI: Bump abi-version break commit

    @3v1n0
    3v1n0 committed May 6, 2022
    Configuration menu
    Copy the full SHA
    d81cc6d View commit details
    Browse the repository at this point in the history

  5. portal: Remove nullable flag from action parameters 

    Variant's can be null on signal emissions, nor can be the case here
because we're getting it parsing a gvariant that will always include an
empty array, in case.
    @3v1n0
    3v1n0 committed May 6, 2022
    Configuration menu
    Copy the full SHA
    65586ca View commit details
    Browse the repository at this point in the history