-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdg-document-portal: implement flock #1353
base: main
Are you sure you want to change the base?
Conversation
Looks like this will block the entire document portal when any file is blocked due to flock. |
Hi, @swick @hfiguiere Thanks for your suggestion! |
Thanks for the patch. Please squash the suggestion commit into a single commit. |
Supporting flock only for certain option is very suspicious to me. This needs review from someone who knows about fuse and filesystems. |
This is needed for Steam client Signed-off-by: Kyohei KADOTA <lufia@lufia.org> Co-authored-by: Hubert Figuière <hub@figuiere.net>
Hello, |
You can give the unofficial Steam Flatpak app direct access to locations where you want to add an extra Steam library by completely exiting from Steam, and then using something like:
before starting Steam again and selecting |
Upon using the override I precisely get the original |
No, the override is sufficient by itself. You do need to restart Steam, and you may need to remove and re-add the library in Steam so it doesn't continue to use the portal path. That error means it's probably still going through the document portal. Also, just to be clear, you need to modify the path to match your actual Steam library location; don't use literally |
Really? I'll take a look and try again in a few days (occupied with moving right now). I actually recall that the override was working for me perfectly fine on the Fedora KDE spin, but somehow it has not been working for me on the Fedora Sway spin. Both installations should have me running on Wayland. I appreciate the input. |
I implemented flock operation of FUSE.
This is needed for Steam client.
Tested
I tested whether the new xdg-document-portal accepts flock(2) syscall with flock(1).
Then, within 100 seconds, I ran flock(1) in other terminal session.
I checked blocking operations are rejected.