Merge pull request #2113 from thofma/th/nmodpoly

fix: nmod_poly with modulus 1
flintlib · Nov 24, 2024 · a8f9854 · a8f9854
2 parents 3c28655 + 1859f82
commit a8f9854
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/nmod_poly.h b/src/nmod_poly.h
@@ -188,20 +188,20 @@ int nmod_poly_is_zero(const nmod_poly_t poly)
 NMOD_POLY_INLINE
 int nmod_poly_is_one(const nmod_poly_t poly)
 {
-    return (poly->mod.n == 0) || (poly->length == 1 && poly->coeffs[0] == 1);
+    return (poly->mod.n == UWORD(1)) || (poly->length == 1 && poly->coeffs[0] == 1);
 }
 
 /* bogus for non-prime modulus */
 NMOD_POLY_INLINE
 int nmod_poly_is_unit(const nmod_poly_t poly)
 {
-    return (poly->length == 1) && poly->coeffs[0] != 0;
+    return (poly->mod.n == UWORD(1)) || ((poly->length == 1) && poly->coeffs[0] != 0);
 }
 
 NMOD_POLY_INLINE
 int nmod_poly_is_gen(const nmod_poly_t poly)
 {
-    return (poly->mod.n == 0) ||
+    return (poly->mod.n == UWORD(1)) ||
            (poly->length == 2 && poly->coeffs[0] == 0 && poly->coeffs[1] == 1);
 }