Remove the flatten on actors to prevent delegator warning. #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 When using Flipper with actors that are
ActiveRecord
models, you get this warning whenever the application checks a feature flag:There is a thread on the Rails Github issues explaining this particular issue, although this is not a big problem per se it does mean the Flipper gem generates unnecessary noise in application logs.
When the passing of multiple arguments was built in, the intent seems to have been to allow the users to pass arguments like:
In this case, the
flatten
does seem like it is not required and could be removed which eliminates the warning?