Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

Commit

Permalink
Clean up dead code, make execute-steps more readable
Browse files Browse the repository at this point in the history
  • Loading branch information
flosell committed Oct 31, 2017
1 parent 5279a40 commit 62ded06
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions src/clj/lambdacd/execution/internal/execute_steps.clj
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,15 @@
(event-bus/unsubscribe ctx :step-result-updated subscription)
result)))


(defn- wrap-filter-nil-steps [handler]
(fn [step-contexts-and-steps args ctx]
(handler (filter (fn [[_ step]] (not-nil? step)) step-contexts-and-steps)
args
ctx)))

; TODO: this should be in a namespace like lambdacd.execution.core?
(defn execute-steps [steps args ctx & {:keys [step-result-producer is-killed unify-results-fn retrigger-predicate]
:or {step-result-producer (serial-step-result-producer)
is-killed (atom false)
unify-results-fn (unify/unify-only-status unify/successful-when-all-successful)
retrigger-predicate retrigger/sequential-retrigger-predicate}}]
(let [handler-chain (-> (call-step-result-producer step-result-producer)
(wrap-inheritance unify-results-fn)
(kill/wrap-execute-steps-with-kill-handling is-killed)
(retrigger/wrap-retrigger-handling retrigger-predicate))]
(handler-chain (contexts-for-steps (filter not-nil? steps) ctx) args ctx)))
(let [handler-chain (-> (call-step-result-producer step-result-producer)
(wrap-inheritance unify-results-fn)
(kill/wrap-execute-steps-with-kill-handling is-killed)
(retrigger/wrap-retrigger-handling retrigger-predicate))
contexts-and-steps (contexts-for-steps (filter not-nil? steps) ctx)]
(handler-chain contexts-and-steps args ctx)))

0 comments on commit 62ded06

Please sign in to comment.