Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in_web] Fix race condition on init. #2455

Merged
merged 7 commits into from
Jan 10, 2020

Commits on Jan 9, 2020

  1. [google_sign_in_web] Wait for Auth2 to be really ready.

    The Auth object that `.init()` returns may not be fully ready by the time
    we start calling methods on it; however it has a `.then()` method that
    gets called when it is *really* ready to go.
    
    * Add a completer to signal when Auth2 is ready.
    * Move auth2-dependent init to the `then` method.
     * onSuccess, complete the auth2 ready future.
     * onError, throw a PlatformException. This is normally triggered when
    the domain:port of the web app hasn't been whitelisted on the google
    sign in console, and things like that. Useful for debugging.
    ditman committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    cc13213 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d4f9da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    14285fc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    520f38b View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. [google_sign_in_web] Throw StateError synchronously if .initialized i…

    …s checked before calling .init()
    ditman committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    95b46d0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74fb7f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f9c0ff3 View commit details
    Browse the repository at this point in the history