Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement
flux debug helmrelease
command #5106Implement
flux debug helmrelease
command #5106Changes from all commits
120ec04
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring a flag for default debug report seems unnecessary. If the intent is to debug, the default output, without any flags, could be the status result.
Instead of
--show-status
, a flag to hide the status when showing other values may have been better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed in the dev meeting. It was agreed that the default output should be a summary of all the helpful details about the release. We can define what should constitute a debug summary result and show that without any flag in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the multi-document YAML output, when both status and values are printed, there's no indication of which part is status and value. Since it's all YAML documents, we can add a comment at the top that tells what the document is. For example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After implementing
flux debug kustomization
I realise that mixing the outputs is not the best idea. Here by chance both flags output YAML, but this is not the case in theflux debug kustomization
. I'm for not allowing both flags to be set, similar to how it's done now in #5117There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Left a comment about the standalone debug status output in that PR which also applies to HR.