Support active record 7.2.0 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for working on this! ❤️ Do you plan to finish this PR soon? |
|
Finished the draft for the pull request and made it public. However, I still don't understand why the CI is failing... |
@hatsu38 great work on this PR! I think the CI issue might be fixed by pinning sqlite3 to version |
hatsu38
force-pushed
the
support-ActiveRecord-7.2.0
branch
from
26c6382
to
b1e7687
Compare
|
@vbiletskii @fatkodima Thanks! I fixed it.⚒️ |
|
I think it is also a good idea to squash commits into one. |
hatsu38
force-pushed
the
support-ActiveRecord-7.2.0
branch
from
b1e7687
to
1390d5b
Compare
|
@hatsu38 thank you so much for supporting active record 7.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.2 is expected to be released soon, so I made this PR to support ActiveRecord 7.2.0.
https://rubygems.org/gems/rails/versions/7.2.0.beta1
Changes:
find_by_sqlmethod have changed.)