Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using domain-qualified finalizers #6023

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

chore: use flyte.org/finalizer instead

202cce9
Select commit
Loading
Failed to load commit list.
Open

chore: using domain-qualified finalizers #6023

chore: use flyte.org/finalizer instead
202cce9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 18, 2024 in 0s

53.65% of diff hit (target 37.03%)

View this Pull Request on Codecov

53.65% of diff hit (target 37.03%)

Annotations

Check warning on line 76 in flyteplugins/go/tasks/plugins/array/k8s/subtask.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/array/k8s/subtask.go#L76 

Added line #L76 was not covered by tests

Check warning on line 140 in flyteplugins/go/tasks/plugins/array/k8s/subtask.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/array/k8s/subtask.go#L140 

Added line #L140 was not covered by tests

Check warning on line 154 in flyteplugins/go/tasks/plugins/array/k8s/subtask.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/array/k8s/subtask.go#L149-L154 

Added lines #L149 - L154 were not covered by tests

Check warning on line 157 in flyteplugins/go/tasks/plugins/array/k8s/subtask.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/array/k8s/subtask.go#L157 

Added line #L157 was not covered by tests

Check warning on line 161 in flyteplugins/go/tasks/plugins/array/k8s/subtask.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/array/k8s/subtask.go#L161 

Added line #L161 was not covered by tests

Check warning on line 259 in flyteplugins/go/tasks/plugins/array/k8s/subtask.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/array/k8s/subtask.go#L259 

Added line #L259 was not covered by tests

Check warning on line 320 in flyteplugins/go/tasks/plugins/array/k8s/subtask.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/array/k8s/subtask.go#L320 

Added line #L320 was not covered by tests

Check warning on line 323 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L323 

Added line #L323 was not covered by tests

Check warning on line 469 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L469 

Added line #L469 was not covered by tests

Check warning on line 523 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L523 

Added line #L523 was not covered by tests

Check warning on line 526 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L526 

Added line #L526 was not covered by tests
View more details on Codecov