Pass CustomInfo metadata through ArrayNode ExternalResourceInfo (#591) #6116
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pass CustomInfo through ArrayNode event recorder Signed-off-by: Daniel Rammer <hamersaw@protonmail.com> * actually doing it Signed-off-by: Daniel Rammer <hamersaw@protonmail.com> * correctly passing custom Signed-off-by: Daniel Rammer <hamersaw@protonmail.com> --------- Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
hamersaw
changed the title
Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6116 +/- ##
=======================================
Coverage 36.98% 36.98%
=======================================
Files 1318 1318
Lines 132473 132479 +6
=======================================
+ Hits 48994 48997 +3
- Misses 79225 79227 +2
- Partials 4254 4255 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pvditt
previously approved these changes
Dec 19, 2024
eapolinario
previously approved these changes
Dec 19, 2024
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
approved these changes
Dec 19, 2024
eapolinario
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
N/A
Why are the changes needed?
Passes
CustomInfofromExternalResourceInfothrough ArrayNode subNode executions.What changes were proposed in this pull request?
^^^
How was this patch tested?
Tested locally.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
N/A
Docs link
N/A