This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Handle batched TaskExecutionEvent reasons #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
…k8s-events Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
andrewwdye
force-pushed
the
k8s-events
branch
from
bc59b73
to
dfa2db6
Compare
andrewwdye
requested review from
katrogan,
wild-endeavor,
EngHabu,
kumare3,
pmahindrakar-oss,
hamersaw and
eapolinario
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 59.01% 60.65% +1.63%
==========================================
Files 171 171
Lines 16468 13469 -2999
==========================================
- Hits 9719 8169 -1550
+ Misses 5899 4449 -1450
- Partials 850 851 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
katrogan
previously approved these changes
Sep 26, 2023
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
katrogan
approved these changes
Sep 27, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 28, 2023
* Handle batched TaskExecutionEvent reasons Signed-off-by: Andrew Dye <andrewwdye@gmail.com> * Add tests Signed-off-by: Andrew Dye <andrewwdye@gmail.com> * Update flyteidl version Signed-off-by: Andrew Dye <andrewwdye@gmail.com> * Update to EventReason Signed-off-by: Andrew Dye <andrewwdye@gmail.com> --------- Signed-off-by: Andrew Dye <andrewwdye@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Handle newly added
TaskExecutionEvent.reasonsfield as part of flyteorg/flyteidl#443.Type
Are all requirements met?
Complete description
This change updates admin to process the recently added
TaskExecutionEvent.reasonsfield, included to support sending batched reason events. This reduces load on both propeller and admin. Admin favors thereasonsfield but falls back to thereasonfield and prior behavior if empty.Tracking Issue
flyteorg/flyte#3825
Follow-up issue
N/A