Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formidable upload issue, fix error handling, do structural refactor #15

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Fix formidable upload issue, fix error handling, do structural refactor #15

merged 2 commits into from
Jul 15, 2024

Conversation

AlexeyNikipelau
Copy link
Contributor

Link to Jira Ticket (if applicable)

https://formio.atlassian.net/browse/FIO-8649

Description

  • Fixed PDF upload caused by updating major version of formidable
  • Fixed error handling to work as designed
  • Structurally refactored

How has this PR been tested?

Manually, both main requests - convertToHtml and getFormfields are working fine now.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@travist travist merged commit 0f81a32 into main Jul 15, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeyNikipelau @travist @lane-formio