Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8733: Update Docker build process #16

Merged
merged 1 commit into from
Jul 25, 2024
Merged

FIO-8733: Update Docker build process #16

merged 1 commit into from
Jul 25, 2024

Conversation

brendanbond
Copy link
Contributor

Link to Jira Ticket (if applicable)

https://formio.atlassian.net/browse/FIO-8733

Description

In an attempt to reduce the number of CVEs detected by Amazon Inspector, we've changed the base image from Ubuntu 24.04 to debian bookworm (12) slim. This means that:

  • pdf2htmlEX still has to be compiled in Ubuntu and moved over
  • some pdf2htmlEX dependencies must be cobbled together in the main image
  • I've gone ahead and removed the chromium install, as pdf-libs has no need for it

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

… (b) targeted build of pdf2htmlEX in ubuntu that is transferred to a slimmer image
@travist
Copy link
Member

travist commented Jul 25, 2024

Tests are failing....

@travist travist merged commit cce6072 into main Jul 25, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants