Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Extra padding-right in the 3 password fields #729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harsh-jindal
Copy link
Member

@harsh-jindal harsh-jindal commented Apr 5, 2019

Fixes #725
Changes: Extra padding-right in the 3 password fields
Surge Deployment Link: https://pr-729-fossasia-susi-accounts.surge.sh

Screenshots for the change: [Add here screenshots depicting the change.]
Screenshot 2019-04-05 at 9 47 49 PM

@harsh-jindal harsh-jindal changed the title Extra padding-right in the 3 password fields Fix Extra padding-right in the 3 password fields Apr 5, 2019
Copy link
Member

@samagragupta samagragupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you replacing PasswordField with TextField.
You can directly change the width.

@harsh-jindal
Copy link
Member Author

@samagragupta PasswordField is having some unexpected behaviour. It is creating a div inside a div and applying css to that. So I tried changing the width but it didn't work. This way should have no problem as the latest material ui also uses this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra padding-right in the 3 password fields
2 participants