Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the UI of Skills similar to skill types in Admin in mobile view #746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harsh-jindal
Copy link
Member

Fixes #745

Changes: Make the UI of Skills similar to skill types in Admin in mobile view.
Surge Deployment Link: https://pr-746-fossasia-susi-accounts.surge.sh

Screenshots for the change:
Screenshot 2019-05-07 at 10 30 17 PM

Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

src/components/Admin/Admin.js Outdated Show resolved Hide resolved
src/components/Admin/Admin.js Outdated Show resolved Hide resolved
@harsh-jindal harsh-jindal force-pushed the B10 branch 2 times, most recently from cd7bef6 to 17968f7 Compare May 8, 2019 05:33
@harsh-jindal
Copy link
Member Author

harsh-jindal commented May 8, 2019

@fragm3 @AakashMallik Made the Changes.Please Review.

@harsh-jindal
Copy link
Member Author

@DNS-404 Please review.

Copy link
Contributor

@fragm3 fragm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

src/components/Admin/Admin.js Outdated Show resolved Hide resolved
src/components/Admin/Admin.js Outdated Show resolved Hide resolved
@harsh-jindal
Copy link
Member Author

@akshatnitd @fragm3 Please review.

src/components/Admin/Admin.js Outdated Show resolved Hide resolved
src/components/Admin/Admin.js Outdated Show resolved Hide resolved
src/components/Admin/Admin.js Outdated Show resolved Hide resolved
@harsh-jindal
Copy link
Member Author

@akshatnitd Made the changes. Please review.

Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra variable declarations at 3 places

src/components/Admin/Admin.js Outdated Show resolved Hide resolved
@harsh-jindal
Copy link
Member Author

@akshatnitd Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the UI of Skills similar to skill types in Admin in mobile view
3 participants