Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In response to Issue #92 Server: Create leader board. #295

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

In response to Issue #92 Server: Create leader board. #295

wants to merge 3 commits into from

Conversation

Daim-Nickel-Penny
Copy link

@Daim-Nickel-Penny Daim-Nickel-Penny commented Aug 29, 2021 •
edited
Loading

In response to Issue #92 Server: Create leader board.

  • Created a leaderboard.html for the project
  • Added stylings to the list
  • The leaderboard is responsive
  • All files are properly indented
  • Tested against various small screen sizes

Files -:
leaderboard.html includes the HTML for the leaderboard where players will be shown
leaderboard.css includes the styling for the leaderboard

@Daim-Nickel-Penny Daim-Nickel-Penny changed the title In response to Issue #92 Server: Create leader board. In response to Issue #295 Server: Create leader board. Aug 30, 2021
@Daim-Nickel-Penny Daim-Nickel-Penny changed the title In response to Issue #295 Server: Create leader board. In response to Issue #92 Server: Create leader board. Aug 30, 2021
abishekvashok
abishekvashok requested changes Sep 6, 2021
View reviewed changes
Copy link
Member

@abishekvashok abishekvashok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking your time working for the project. I believe the idea of the leaderboard was not to have a static website but rather a dynamic one that can update based on points scored by users playing the game. How does that sound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abishekvashok abishekvashok abishekvashok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daim-Nickel-Penny @abishekvashok