Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-9075: Remove empty line, add - in format jinja2 to remove empty l… #9091

Closed
wants to merge 9 commits into from
Closed

fix-9075: Remove empty line, add - in format jinja2 to remove empty l… #9091

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 13, 2023 •
edited by ghost
Loading

…ine if do not have data

Fixes #9075

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@ghost ghost requested review from mariobehling and cweitat October 13, 2023 05:00
@cweitat
Copy link
Contributor

cweitat commented Oct 15, 2023

@lthanhhieu pls show a screenshot/pdf of the printed badge

mariobehling
mariobehling requested changes Oct 15, 2023
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are "Multiple Migration Heads". Please resolve.

@marcoag marcoag requested a review from mariobehling October 21, 2023 21:02
marcoag
marcoag reviewed Oct 22, 2023
View reviewed changes
app/api/custom/check_in_stats.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand from the description that this PR fixes the extra empty line on QR codes for checkin attendees. But the modifications on this file seem related to check-in stats. Just trying to understand, could you explain how this changes are related? thanks in advance!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that merge from this branch https://github.com/lthanhhieu/open-event-server/tree/lthanhhieu-tma/feature-9077 to fix issue in UT Test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the combination of two PR/feature branches?
That is not good, please separate them or do them one by one, otherwise we cannot reasonably review code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review the PR 9077 first, after that I will change this PR as well.

@ghost ghost closed this by deleting the head repository Mar 19, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitat cweitat Awaiting requested review from cweitat

@mariobehling mariobehling Awaiting requested review from mariobehling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QR VCard format generated for badge not formatted correctly
4 participants
@cweitat @mariobehling @norbusan @marcoag