-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-9075: Remove empty line, add - in format jinja2 to remove empty l… #9091
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cbca673
fix-9075: Remove empty line, add - in format jinja2 to remove empty l…
5afcdea
feature-9077: Missing stats for daily check in scanning returning fro…
84a2854
feature-9077: Missing stats for daily check in scanning returning fro…
4c21f71
feature-9077: Missing stats for daily check in scanning returning fro…
e4e1c3f
feature-9077: Missing stats for daily check in scanning returning fro…
b42a000
feature-9077: Missing stats for daily check in scanning returning fro…
0fc3e0a
fix-9075: Fix 2heads
459f296
Merge branch 'lthanhhieu-tma/feature-9077' into lthanhhieu-tma/fix-9075
8ae57a3
fix-9075: Fix image
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand from the description that this PR fixes the extra empty line on QR codes for checkin attendees. But the modifications on this file seem related to check-in stats. Just trying to understand, could you explain how this changes are related? thanks in advance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that merge from this branch https://github.com/lthanhhieu/open-event-server/tree/lthanhhieu-tma/feature-9077 to fix issue in UT Test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is the combination of two PR/feature branches?
That is not good, please separate them or do them one by one, otherwise we cannot reasonably review code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review the PR 9077 first, after that I will change this PR as well.