filter: fix end second parsing #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@james-rms thoughts on @bennetthardwick's comment here? #1268 (comment) |
james-rms
force-pushed
the
james/fg-9465-mcap-filter-with-e-s-not-behaving-correctly
branch
from
b3651fc
to
24561c5
Compare
james-rms
force-pushed
the
james/fg-9465-mcap-filter-with-e-s-not-behaving-correctly
branch
from
24561c5
to
a3b6203
Compare
|
@jtbandes that one is a red herring - it does nothing. I've deleted it in this PR. |
jtbandes
approved these changes
Nov 13, 2024
|
Any tests we can add for this? |
james-rms
deleted the
james/fg-9465-mcap-filter-with-e-s-not-behaving-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
-eargument tomcap filterwill be interpreted properly again.Docs
None.
Description
The last change to
filtermistakenly swapped thenanosandsecondsarguments toparseTimestampArgsfor the filter end time.Testing
mcap filter -s 10 -e 1000manually, previously failed, now works.Fixes: #1268