Remove to_f in set method to prevent error
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents a `NoMethodError` when retrying jobs or scheduling jobs with `set(wait: ...)` for adapters like GoodJob and Solid Queue.
ahacop
force-pushed
the
fix-set-wait-and-retry
branch
from
1c23dc3
to
dc546cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents a
NoMethodErrorwhen retrying jobs or scheduling jobs withset(wait: ...)for adapters like GoodJob and Solid Queue.Fixes #92.
I added a test to check that scheduled_at is not cast. I wasn't sure if you thought it was necessary to bring in Solid Queue or Good Job to actually test those adapters. Happy to make changes if you have other suggestions on how to test here.