Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch the action_dispatch executor to report rendered exceptions #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fractaledmind
Copy link
Owner

Resolves #12

@holman
Copy link

holman commented Feb 8, 2024

Now I'm seeing this:

Puma caught this error: super: no superclass method `call' for #<ActionDispatch::Executor:0x000000010646e310
[...]

@fractaledmind
Copy link
Owner Author

I really don't want to have to put a workaround into this gem.

I have finished my investigation and I wrote a detailed explanation of what is happening: rails/rails#51002 (comment)

Takeaway: there is definitely an issue here, and Rails applications will not report errors that occur within the HTTP lifecycle unless reloading is enabled.

Hopefully we can get a resolution in upstream Rails instead of this still-not-working hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

production not seeing most exceptions
2 participants