Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mailer #26

Closed
wants to merge 1 commit into from
Closed

Fix mailer #26

wants to merge 1 commit into from

Conversation

dorianmariecom
Copy link
Contributor

It was missing an occurence_counter local variable

@dorianmariecom
Fix mailer
bc29d30 
It was missing an occurence_counter local variable
@dorianmariecom
Copy link
Contributor Author

Fixes #22

@fractaledmind
Copy link
Owner

Thank you for this PR, but I prefer the fix in #28. I shouldn't have relied so implicitly on the behavior of render when passed a collection, and the semantics used are a bit confusing. I like clearing up the semantics and providing a default.

@dorianmariecom dorianmariecom deleted the dorian/fix-mailer branch February 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorianmariecom @fractaledmind