-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add one_email_per_occurrence option and migration task #53
base: main
Are you sure you want to change the base?
Commits on Jul 17, 2024
-
Add one_email_per_occurrence option and migration task
Introduce the one_email_per_occurrence configuration option to limit email notifications to one per occurrence. Updated README and error controller to support the new feature, and added Rake task to handle migrations.
Configuration menu - View commit details
-
Copy full SHA for 7bc8480 - Browse repository at this point
Copy the full SHA 7bc8480View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f18111 - Browse repository at this point
Copy the full SHA 9f18111View commit details
Commits on Jul 18, 2024
-
Adjustments from feedback on PR
- Converted prev_resolved_at to a datetime from a timestamp in migration - Added a method `should_send_email?` to determine if an email goes instead of a string of conditionals - Cleaned up guard clauses - Improved the datetime comparison in an AR query
Configuration menu - View commit details
-
Copy full SHA for b2e1ded - Browse repository at this point
Copy the full SHA b2e1dedView commit details -
Refactor solid_errors_tasks.rake to remove hardcoded migrations
The refactor involved removing a segment which forced a specific migration to run in favor of Rails' mechanism of alerting when migrations are pending. The prior method was too rigid and hard-coded. Now, the system still copies the migration over but doesn't automatically run it.
Configuration menu - View commit details
-
Copy full SHA for 319fa02 - Browse repository at this point
Copy the full SHA 319fa02View commit details -
Rework 'prev_resolved_at' from error_params
The 'prev_resolved_at' parameter has been removed from the error_params in the errors_controller, and subsequently from the error buttons in the views. Meanwhile, in the subscriber, 'prev_resolved_at' is now updated with the current 'resolved_at' before this is set to nil, maintaining the history of resolution times.
Configuration menu - View commit details
-
Copy full SHA for 5fe0e51 - Browse repository at this point
Copy the full SHA 5fe0e51View commit details -
Refactor email sending condition in SolidErrors
Simplified the condition check whether to send an email in SolidErrors::Occurrence. The method should_send_email? now has guard clauses if SolidErrors does not send emails or if no email recipient is set. Additionally, the instance method one_email_per_occurrence is renamed to one_email_per_occurrence? to follow the naming convention like `send_emails?`.
Configuration menu - View commit details
-
Copy full SHA for c47a881 - Browse repository at this point
Copy the full SHA c47a881View commit details -
Remove one_email_per_occurrence config option from SolidErrors
The config option that limits the email notifications to one email per error occurrence in the SolidErrors has been removed and, instead, that approach is used automatically (sending one per occurrence). Corrections were also made to the post-install message in the gemspec file to remove the ``*and* runs` from the note since we are not auto-running migrations.
Configuration menu - View commit details
-
Copy full SHA for 8719f90 - Browse repository at this point
Copy the full SHA 8719f90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 212e5ff - Browse repository at this point
Copy the full SHA 212e5ffView commit details -
Make email sending condition consistent style; update migration copyi…
…ng process In the 'Occurrence' model, the condition checking if an error has only one occurrence has been simplified by replacing 'count == 1' with 'one?'. In the rake task, the file copying process from Solid Errors to Rails application has been altered so that instead of copying the file directly, it's named with a timestamp before copying to avoid potential naming conflicts. The migration file name was also simplified by removing the timestamp so that we can dynamically add one.
Configuration menu - View commit details
-
Copy full SHA for b78a6e9 - Browse repository at this point
Copy the full SHA b78a6e9View commit details -
Update file existence check in solid_errors_tasks
This patch replaces the original file existence check so that it now checks if there are any files with the same original filename (no timestamp) in the entire directory structure under the destination path. This avoids unnecessary file copy operations.
Configuration menu - View commit details
-
Copy full SHA for b728c2c - Browse repository at this point
Copy the full SHA b728c2cView commit details
Commits on Jul 19, 2024
-
Simplify file search in solid_errors_tasks rake task
Don't need nested directory in glob
Configuration menu - View commit details
-
Copy full SHA for 20bf39a - Browse repository at this point
Copy the full SHA 20bf39aView commit details -
Co-authored-by: Stephen Margheim <stephen.margheim@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3c41ab2 - Browse repository at this point
Copy the full SHA 3c41ab2View commit details -
Update lib/tasks/solid_errors_tasks.rake
Co-authored-by: Stephen Margheim <stephen.margheim@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3f3ae1e - Browse repository at this point
Copy the full SHA 3f3ae1eView commit details -
Update lib/tasks/solid_errors_tasks.rake
Co-authored-by: Stephen Margheim <stephen.margheim@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cf27fc6 - Browse repository at this point
Copy the full SHA cf27fc6View commit details -
Update README and solid_errors tasks
Added instructions to README file for running migration installer after updating the gem. Also, refactored 'solid_errors_tasks.rake' by simplifying the filename generation process during migration. These changes facilitate smoother gem updates and migrations.
Configuration menu - View commit details
-
Copy full SHA for e3fc454 - Browse repository at this point
Copy the full SHA e3fc454View commit details -
Configuration menu - View commit details
-
Copy full SHA for bac9123 - Browse repository at this point
Copy the full SHA bac9123View commit details
Commits on Jul 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32f3242 - Browse repository at this point
Copy the full SHA 32f3242View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3843711 - Browse repository at this point
Copy the full SHA 3843711View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f4755c - Browse repository at this point
Copy the full SHA 7f4755cView commit details
Commits on Jul 23, 2024
-
This version (x.003) has changes that ensure the migration is copied to the containing application.
Configuration menu - View commit details
-
Copy full SHA for 3fad88f - Browse repository at this point
Copy the full SHA 3fad88fView commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0c16934 - Browse repository at this point
Copy the full SHA 0c16934View commit details