Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[franka_description] Use proper title; make more searchable #302

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

EricCousineau-TRI
Copy link

During investigation that yielded #300 #301

Use slightly more proper notation style
Copy link
Contributor

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricCousineau-TRI, thank you for submitting this pull request. I believe it's a valuable addition, as it provides essential information to users about the origin of simulated inertia values – great job! 👍🏻

@Maverobot, I apologize for tagging you in multiple PRs, but considering that this pull request only modifies docstrings, I believe it can be merged seamlessly without any concerns. Your input on this would be appreciated.

@rickstaa
Copy link
Contributor

rickstaa commented Sep 4, 2023

@EricCousineau-TRI, would it be possible to consider changing the PR title and commit message to something like:

docs(franka_gazebo): add inertia properties reference

This adjustment would make it more evident at a glance what the PR is focused on, as the current title doesn't immediately convey its purpose.

@Maverobot
Copy link
Contributor

@rickstaa No problem. :D Since I will leave Franka soon, please consider tagging someone else such as @FE-EnricoSartori so that the progress can be better tracked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants